Run unit test suites in parallel#4190
Conversation
Signed-off-by: Simeon Widdis <sawiddis@gmail.com>
Swiddis
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
Swiddis
added
the
infrastructure
|
I haven't tested out but thanks for doing this. |
|
Does this fixing save time of integ-test for building locally with |
|
It reduces the github CI but not very much -- the individual tasks are parallelized now (so e.g. The problem with enabling parallelism between tasks right now is it seems there's an invisible dependency for Something we could do is break up our testing action into unit tests, integTest, and doctest as three different actions. Then we run |
#4193, looks like it works. If preferred, close this in favor of that, but I'd rather get this merged quicker since it has immediate benefit for local development, and don't want to block this on any issues with those (riskier) CI updates. |
penghuo
left a comment
penghuo
left a comment
There was a problem hiding this comment.
Thanks.
Could u update doc also. https://github.com/opensearch-project/sql/blob/main/DEVELOPER_GUIDE.rst#building-and-running-tests
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
|
Test failures pending #4215, was passing before doc update |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
This reverts commit 65461ad. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
force-pushed
the
feature/parallel-tests
branch
from
f99b5c7 to
ea3420a
Compare
4 participants
Description
Our unit tests don't have any cross-dependency, so we can freely turn on parallelization for them. Makes builds a bit faster locally. (At least the parts where most of the feedback is -- async is still slow but now it runs at the end instead of the start, and will rarely fail when working on anything that isn't specifically async.)
Related Issues
Slow local builds. I want
./gradlew -x doctest -x integTest --parallelto be fast.Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.